use try with resources in JsonUtil #9879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
According to Sonarcloud:
"Failure to properly close resources will result in a resource leak which could bring first the application and then perhaps the box the application is on to their knees."
Which issue(s) this PR closes:
Special notes for your reviewer:
You can see the bug at
https://sonarcloud.io/code?id=IQSS_dataverse&selected=IQSS_dataverse%3Asrc%2Fmain%2Fjava%2Fedu%2Fharvard%2Fiq%2Fdataverse%2Futil%2Fjson%2FJsonUtil.java
Unfortunately, Netbeans didn't flag this error for me locally and therefore didn't offer any kind of automatic fix. Netbeans does seem to have the right rule enabled:
I ended up following https://guides.dataverse.org/en/5.14/developers/tools.html#sonarqube more or less to set up SonarQube and used the following script to test just the one file I was editing:
Suggestions on how to test this:
This change is covered by unit tests, so I don't think manual testing is required. However, loading an external tool should test it.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
None. However, we now have an issue about Sonar: